Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): gracefully handle failure to generate an aab diff #922

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

Print warning instead of crashing if we can't compute a diff between two aabs

Fixes #857

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (775fed6) 100.00% compared to head (25a1911) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #922   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           78        78           
  Lines         2833      2836    +3     
=========================================
+ Hits          2833      2836    +3     
Files Changed Coverage Δ
...ebird_cli/lib/src/archive_analysis/aab_differ.dart 100.00% <100.00%> (ø)
.../lib/src/commands/patch/patch_android_command.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@bryanoltman bryanoltman merged commit c6ef36f into main Jul 26, 2023
7 checks passed
@bryanoltman bryanoltman deleted the bo/asset-diff-fail branch July 26, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on patch, after use shorebird release android --artifact=apk
2 participants