docs: add thoughts on future design #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 96.27% 96.03% -0.24%
==========================================
Files 28 20 -8
Lines 3191 2898 -293
==========================================
- Hits 3072 2783 -289
+ Misses 119 115 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bryanoltman
reviewed
May 8, 2024
README.md
Outdated
| library from within a Flutter app. Published to pub.dev, usage is optional by | ||
| developers. | ||
|
|
||
| Mos interesting code is in the `library` directory. There is also |
There was a problem hiding this comment.
Suggested change
| Mos interesting code is in the `library` directory. There is also | |
| Most interesting code is in the `library` directory. There is also |
erickzanardo
reviewed
May 8, 2024
README.md
Outdated
| library from within a Flutter app. Published to pub.dev, usage is optional by | ||
| developers. | ||
|
|
||
| Mos interesting code is in the `library` directory. There is also |
There was a problem hiding this comment.
Suggested change
| Mos interesting code is in the `library` directory. There is also | |
| Most interesting code is in the `library` directory. There is also |
bryanoltman
reviewed
May 8, 2024
bryanoltman
reviewed
May 8, 2024
patch/README.md
Outdated
| and we intend to move to a system whereby `patch` is responsible for including | ||
| its own hash in the patch file and validating during application. | ||
|
|
||
| In that world we might end up with two hashes. One who's purpose is to validate |
There was a problem hiding this comment.
Suggested change
| In that world we might end up with two hashes. One who's purpose is to validate | |
| In that world we might end up with two hashes. One whose purpose is to validate |
erickzanardo
reviewed
May 8, 2024
patch/README.md
Outdated
| and we intend to move to a system whereby `patch` is responsible for including | ||
| its own hash in the patch file and validating during application. | ||
|
|
||
| In that world we might end up with two hashes. One who's purpose is to validate |
There was a problem hiding this comment.
Suggested change
| In that world we might end up with two hashes. One who's purpose is to validate | |
| In that world we might end up with two hashes. One who's purpose is to validate |
erickzanardo
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.