Skip to content
This repository has been archived by the owner on Oct 17, 2020. It is now read-only.

[REFACTOR] [UI] $content-width SCSS variable not responsive to all screen sizes #722

Open
Coteh opened this issue Apr 29, 2020 · 2 comments
Open

[REFACTOR] [UI] $content-width SCSS variable not responsive to all screen sizes #722

Coteh opened this issue Apr 29, 2020 · 2 comments
Labels
good first issue Good for newcomers maintainability

Comments

@Coteh
Copy link
Collaborator

Coteh commented Apr 29, 2020

What is frustrating you?
The $content-width SCSS variable, found in frontend/src/component/styles/dimension.scss is set to 1200px currently, which works for desktop, but does not make sense for mobile. Components affected are: Header, Footer (but it looks fine since it's centered and just text), Section, and UserShortLinksSection.

Your solution
Refactor so that the $content-width variable's value is calculated from the current screen width.

Screenshots
iPhone X/XS screen dimensions for example:
image
@magicoder10
Copy link
Member

You mean not responsive

@Coteh
Copy link
Collaborator Author

Coteh commented Apr 29, 2020 via email

@Coteh Coteh changed the title [REFACTOR] [UI] $content-width SCSS variable not sensible for all screen sizes [REFACTOR] [UI] $content-width SCSS variable not responsive to all screen sizes Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers maintainability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Coteh @magicoder10