Use deep copy so that all arguments are copied by value (Sourcery refactored)

[sourcery-ai]

Pull Request #66 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

1. Merge this Pull Request instead of the original, or

2. Ask your contributor to locally incorporate these commits and push them to
   the original Pull Request

   Incorporate changes via command line

   git fetch https://github.com/shosca/django-rest-witchcraft pull/66/head
   git merge --ff-only FETCH_HEAD
   git push

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

[sourcery-ai]

Function ModelSerializer.get_field_names refactored with the following changes:

• Simplify logical expression using De Morgan identities (de-morgan)

[sourcery-ai]

Function ModelSerializer.get_nested_relationship_fields refactored with the following changes:

• Convert for loop into set comprehension (set-comprehension)

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.06%.

Quality metrics	Before	After	Change
Complexity	8.23 ⭐	8.19 ⭐	-0.04 👍
Method Length	58.00 ⭐	57.88 ⭐	-0.12 👍
Working memory	10.55 😞	10.57 😞	0.02 👎
Quality	64.46% 🙂	64.52% 🙂	0.06% 👍

Other metrics	Before	After	Change
Lines	784	788	4

Changed files	Quality Before	Quality After	Quality Change
rest_witchcraft/serializers.py	64.46% 🙂	64.52% 🙂	0.06% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
rest_witchcraft/serializers.py	ModelSerializer.perform_update	43 ⛔	190 😞	17 ⛔	20.57% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
rest_witchcraft/serializers.py	ModelSerializer.get_field_names	17 🙂	190 😞	13 😞	38.32% 😞	Try splitting into smaller methods. Extract out complex expressions
rest_witchcraft/serializers.py	BaseSerializer.build_standard_field_kwargs	11 🙂	140 😞	19 ⛔	41.78% 😞	Try splitting into smaller methods. Extract out complex expressions
rest_witchcraft/serializers.py	ModelSerializer.build_nested_field	6 ⭐	145 😞	14 😞	50.91% 🙂	Try splitting into smaller methods. Extract out complex expressions
rest_witchcraft/serializers.py	ExpandableModelSerializer.to_representation	4 ⭐	91 🙂	22 ⛔	52.92% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.