Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1649 Add a microbenchmark for QueryCounter #1663

Conversation

justinweng-instaclustr
Copy link
Collaborator

This PR adds a benchmark function for QueryCounter which includes a chain of QueryCounter followed by Loopback. It sends several redis commands to trigger the increment of the QueryCounter metric.

Progress towards #1649

Copy link

codspeed-hq bot commented Jun 14, 2024

CodSpeed Performance Report

Merging #1663 will degrade performances by 11.57%

Comparing justinweng-instaclustr:1649-write-microbenchmark-for-querycounter (c75dc1b) with main (42ed20d)

Summary

❌ 1 regressions
✅ 36 untouched benchmarks

🆕 1 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main justinweng-instaclustr:1649-write-microbenchmark-for-querycounter Change
🆕 query_counter N/A 14.1 µs N/A
encode_system.local_result_v5_no_compression 92.8 µs 104.9 µs -11.57%

@rukai
Copy link
Member

rukai commented Jun 14, 2024

for the regression on the encode_system.local_result_v5_no_compression benchmark, I think that changing the benchmarks has just added some noise by making the benchmark executable compile slightly differently or leave the heap in a slightly different state.

So dont worry about it.

@justinweng-instaclustr justinweng-instaclustr marked this pull request as ready for review June 14, 2024 03:23
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@justinweng-instaclustr justinweng-instaclustr merged commit d150aab into shotover:main Jun 14, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants