Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1656 Split up scram_over_mtls module into submodules #1679

Conversation

justinweng-instaclustr
Copy link
Collaborator

@justinweng-instaclustr justinweng-instaclustr commented Jul 2, 2024

This PR splits up the original monolithic module scram_over_mtls into submodules recreate_token_queue and create_token in order to prepare for the improvement on token handling in #1667. It doesn't change the functionality of the module scram_over_mtls.

Closes #1656

Copy link

codspeed-hq bot commented Jul 2, 2024

CodSpeed Performance Report

Merging #1679 will create unknown performance changes

Comparing justinweng-instaclustr:1656-splitup-scram_over_mtls-module (c657ae9) with main (9c00122)

Summary

🆕 39 new benchmarks

Benchmarks breakdown

Benchmark main justinweng-instaclustr:1656-splitup-scram_over_mtls-module Change
🆕 cassandra_protect_protected N/A 74.4 µs N/A
🆕 cassandra_protect_unprotected N/A 43 µs N/A
🆕 cassandra_request_throttling_unparsed N/A 14.7 µs N/A
🆕 cassandra_rewrite_peers_passthrough N/A 81.6 µs N/A
🆕 loopback N/A 6.4 µs N/A
🆕 nullsink N/A 14 µs N/A
🆕 query_counter_fresh N/A 15.4 µs N/A
🆕 query_counter_pre_used N/A 11.9 µs N/A
🆕 redis_cluster_ports_rewrite N/A 18.9 µs N/A
🆕 redis_filter N/A 22.2 µs N/A
🆕 decode_system.local_query_v4_lz4_compression N/A 54.9 µs N/A
🆕 decode_system.local_query_v4_no_compression N/A 54.7 µs N/A
🆕 decode_system.local_query_v5_lz4_compression N/A 56.9 µs N/A
🆕 decode_system.local_query_v5_no_compression N/A 56.8 µs N/A
🆕 decode_system.local_result_v4_lz4_compression N/A 44.9 µs N/A
🆕 decode_system.local_result_v4_no_compression N/A 14.9 µs N/A
🆕 decode_system.local_result_v5_lz4_compression N/A 44.8 µs N/A
🆕 decode_system.local_result_v5_no_compression N/A 14.8 µs N/A
🆕 encode_system.local_query_v4_lz4_compression N/A 14.5 µs N/A
🆕 encode_system.local_query_v4_no_compression N/A 14.5 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@justinweng-instaclustr justinweng-instaclustr marked this pull request as ready for review July 2, 2024 23:42
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pasted the moved code into a diff tool and can confirm that the code is unchanged, except for a few error message typo fixes.
Nice!

@justinweng-instaclustr
Copy link
Collaborator Author

I pasted the moved code into a diff tool and can confirm that the code is unchanged, except for a few error message typo fixes. Nice!

Thanks for checking! JOOC, what diff tool did you use?

@rukai
Copy link
Member

rukai commented Jul 3, 2024

Thanks for checking! JOOC, what diff tool did you use?

Not sure 🤣
I googled "web diff tool" and picked the first result.

@rukai
Copy link
Member

rukai commented Jul 3, 2024

From my history it was: https://www.diffchecker.com/

@justinweng-instaclustr justinweng-instaclustr merged commit f53bf73 into shotover:main Jul 3, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

splitup the scram_over_mtls module.
3 participants