Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSinkCluster - improve metadata response rewriting #1740

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Aug 29, 2024

Previously we were exposing internal cluster BrokerId's to the client.
However these need to be rewritten to the BrokerId's used by the shotover instances.
This PR introduces the required message rewriting logic.

The isr_nodes (in-sync-replica nodes) can follow the same logic as replica_nodes, so the logic is just copied over from there.

Copy link

codspeed-hq bot commented Aug 29, 2024

CodSpeed Performance Report

Merging #1740 will not alter performance

Comparing rukai:improve_metadata_rewriting (5100e5e) with main (0d50ddd)

Summary

✅ 39 untouched benchmarks

@rukai rukai marked this pull request as ready for review August 29, 2024 05:02
@rukai rukai force-pushed the improve_metadata_rewriting branch from ec5eee1 to 5100e5e Compare August 29, 2024 06:47
@rukai rukai merged commit 57a1362 into shotover:main Aug 29, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants