Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A Bug?] The diffused boxes as input may have negative coordinates. #33

Closed
YTEP-ZHI opened this issue Dec 14, 2022 · 2 comments
Closed

Comments

@YTEP-ZHI
Copy link

x = torch.clamp(x, min=-1 * self.scale, max=self.scale)
x = ((x / self.scale) + 1) / 2.
diff_boxes = box_cxcywh_to_xyxy(x)

Though you clamped the coordinates (x) at line400, they may become negative number when converted from (cx, cy, w, h) to (x, y, x, y) mode. Here is an example:

image

It happens when cx or cy is close to zero (or clamped to zero), if conducting cx - w/2 or cy - h/2, it becomes negative number.

Is it acceptable to pass the negative coordinates to the RCNN head? Will it cause any unexpected behavior extracting roi feature?

@ShoufaChen
Copy link
Owner

Hi,

Thanks for your interest.

Yes, the RCNN head can accept negative coordinates.

@YTEP-ZHI
Copy link
Author

Thanks for your reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants