Feature/seext 7692 babel cache issue #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomislavherman
suggested changes
Apr 29, 2020
package.json
Outdated
| "lint": "eslint ./ --ignore-pattern build --ignore-pattern templates", | ||
| "test": "mocha -R spec --require fetch-everywhere --compilers js:babel-core/register \"src/**/*spec.js\"", | ||
| "shoutem": "node build/shoutem.js", | ||
| "dev": "node src/shoutem.js", | ||
| "prepublish": "dos2unix src/shoutem.js", |
There was a problem hiding this comment.
Add && npm run build to prepublish script
src/cli.js
Outdated
| return null; | ||
| } | ||
| await authorizeRequests(await getRefreshToken()); | ||
| const refreshToken = await getRefreshToken(); | ||
| authorizeRequests(refreshToken); |
There was a problem hiding this comment.
This call was awaited before. Please check if this call should still be awaited and add await if required.
tomislavherman
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
It's ok regarding my previous comments. @Definitely-Not-Vlad can you please see if there are some potential problems with this. Basically, few files are reverted to state before your commit on Mar 12: Reset to v0.10.11. As I can see these changes include:
- starting cli from build folder
- disabling dynamic babel transpilation (babel/register) if code is started from build folder
- passing arguments to autoUpdate call
Definitely-Not-Vlad
approved these changes
Apr 30, 2020
There was a problem hiding this comment.
LGTM, taking into account @tomislavherman's "reverted" commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.