Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update Lerna, and changed versions required in peer dependencies. #333

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/unlucky-roses-hammer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@showbie/eslint-config': patch
'@showbie/eslint-config-ember': patch
'@showbie/eslint-config-react': patch
'@showbie/eslint-config-typescript': patch
---

Updated peer dependencies so things can install better.
12 changes: 4 additions & 8 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ jobs:
- name: Checkout repo
uses: actions/checkout@v2

- name: Setup Node.js 16.x
uses: actions/setup-node@v2.5.1
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version-file: '.nvmrc'

# Create a temp .npmrc to authenticate with GPR.
- name: Create CI .npmrc
Expand All @@ -26,14 +26,10 @@ jobs:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

# https://github.com/bahmutov/npm-install
# Custom install command to prevent husky from installing.
- name: Install dependencies
uses: bahmutov/npm-install@v1
with:
install-command: npm ci --ignore-scripts --no-audit --legacy-peer-deps

- name: Bootstrap monorepo
run: npm run bootstrap
install-command: npm ci --ignore-scripts --no-audit

- name: Lint
run: npm run lint
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
fetch-depth: 0

# https://github.com/actions/setup-node/
- name: Setup Node.js 16.x
uses: actions/setup-node@v2.5.1
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version-file: '.nvmrc'

# Create a temp .npmrc to authenticate with GPR.
- name: Create CI .npmrc
Expand All @@ -33,11 +33,10 @@ jobs:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

# https://github.com/bahmutov/npm-install
# Custom install command to prevent husky from installing.
- name: Install dependencies
uses: bahmutov/npm-install@v1
with:
install-command: npm ci --ignore-scripts --no-audit --legacy-peer-deps
install-command: npm ci --ignore-scripts --no-audit

# https://github.com/changesets/action
- name: Create release PR or publish to registry
Expand Down
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
@showbie:registry=https://npm.pkg.github.com
//npm.pkg.github.com/:_authToken=${GITHUB_REGISTRY_TOKEN}
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
lts/hydrogen
6 changes: 2 additions & 4 deletions lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
"message": "Chore: Publish release"
}
},
"packages": [
"packages/*"
],
"version": "independent"
"version": "independent",
"$schema": "node_modules/lerna/schemas/lerna-schema.json"
}
Loading
Loading