Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added video tutorial for rush installation. #29

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

zainulhassan815
Copy link
Contributor

No description provided.

Repository owner deleted a comment from height bot Oct 14, 2021
Copy link
Owner

@shreyashsaitwal shreyashsaitwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zainulhassan815 Thanks for the PR. But IMO, it'd be better if we had a separate section named something like "Useful links" at the bottom of the README and add your video link there. Something like this:

Useful links

Video: How to install Rush by @zainulhassan815

README.md Outdated Show resolved Hide resolved
@shreyashsaitwal shreyashsaitwal self-assigned this Oct 14, 2021
@shreyashsaitwal shreyashsaitwal added the documentation Improvements or additions to documentation label Oct 14, 2021
Co-authored-by: Shreyash Saitwal <40118018+shreyashsaitwal@users.noreply.github.com>
@zainulhassan815
Copy link
Contributor Author

Yeah I think it would be better as we can later add other useful links.

@shreyashsaitwal
Copy link
Owner

shreyashsaitwal commented Nov 4, 2021

@zainulhassan815 Can you make the suggested changes so that I can go ahead and merge this?

@shreyashsaitwal shreyashsaitwal merged commit 12aa49d into shreyashsaitwal:main Nov 25, 2021
shreyashsaitwal pushed a commit that referenced this pull request Aug 15, 2022
* Added video tutorial for rush installation.

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants