SHRINKRES-277 Upgraded to maven-invoker 3.0.0 #122
Conversation
| assertEquals(userSettingFile, invocationRequest.getUserSettingsFile()); | ||
| assertEquals(true, invocationRequest.isActivatedReactor()); | ||
| assertEquals(builderId, invocationRequest.getBuilder()); |
There was a problem hiding this comment.
One handy tip here would be to use assertj with its soft-assertions. This way you would have a chance to gather all the failed conditions in one test execution rather than discovering them one after the other.
There was a problem hiding this comment.
Also maybe worth to split this test to multiple ones if we test more than one aspect of the build here?
There was a problem hiding this comment.
soft assertions make more sense...
| @@ -14,7 +14,6 @@ | |||
| <description>Implementation for running Maven builds and retrieving information and archives from the built project</description> | |||
|
|
|||
| <properties> | |||
| <version.maven.invoker>2.2</version.maven.invoker> | |||
There was a problem hiding this comment.
We could update spacelift too ;)
There was a problem hiding this comment.
will apply on all properties - will be part of next commit
There was a problem hiding this comment.
next commit - not part of this PR
|
Any idea why the build is failing? |
|
nope, no idea |
|
Thx for review @bartoszmajsak |
No description provided.