[SHRINKWRAP-261] Maven shortcut API

[samaxes]

Shorthand for including maven artifacts
https://issues.jboss.org/browse/SHRINKWRAP-261

[samaxes]

Andrew, there is a reason for this, from https://issues.jboss.org/browse/SHRINKWRAP-261:

The code uses the Validate class from impl-maven, so if no one has any objection to this, the Shortcut API will be on impl-maven project and not on api-maven.

Should we move Validate class to api-maven?

[kpiwko]

Samuel, why you recopied all the MavenBuilderImpl internals into MavenResolver? Any tough points to use it directly? I don't like the idea of having similar functionality twice in the code.

Andrew, indirection requires rewriting of DependencyBuilderInstantiator. It would make sense to have it done similarly to LoadableExtension which is in Arquillian. I think this might be done during API cleanup, where we should actually think of hiding all of impl classes, which might confuse user. I have no problem to accept in impl-maven and refactor later.

[samaxes]

Karel, honestly I don't remember the reason anymore.
I've implemented it back in June - shrinkwrap/shrinkwrap#25.

I will have a closer look at this by the weekend.
If you have any suggestion please let me know.

[samaxes]

Hi Karel and Andrew,

I'm pretty confident that this is very close to the best we can do with the current API.

Only a very compact class (Maven class) is exposed to the user under the Maven API.
Most of the implementation code is "hidden" in the impl-maven module.

The new Shortcut API can be used like this:

Maven.dependency("org.jboss.shrinkwrap.test:test-deps-c:1.0.0")
Maven.dependencies("org.jboss.shrinkwrap.test:test-deps-c:1.0.0", "org.jboss.shrinkwrap.test:test-deps-g:1.0.0")
Maven.withPom("test-pom.xml").dependency("org.jboss.shrinkwrap.test:test-deps-c:1.0.0")
Maven.withPom("test-pom.xml").dependencies("org.jboss.shrinkwrap.test:test-deps-c:1.0.0", "org.jboss.shrinkwrap.test:test-deps-g:1.0.0")

[kpiwko]

This condition is not enough, you should verify there was exactly one jar

[samaxes]

All changes done, please validate.

[kpiwko]

Merged and pushed upstream as c2367b5. Thanks!