Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release workflow failing due to branch protection issues #31

Merged
merged 2 commits into from
Sep 3, 2023

Conversation

shtaif
Copy link
Owner

@shtaif shtaif commented Sep 3, 2023

Trying to fix the state of affairs: without providing any token for the actions/checkout@v3 action step as well as if passing the built-in secrets.GITHUB_TOKEN to it - the semantic release action later on would end up unauthorized to push changes to master since it is set with branch protection, more reference for this issue on: semantic-release/semantic-release#2636 (comment).

I've created a new SEMANTIC_RELEASE_ACTION_PAT secret for this repo as implied with some PAT I generated.

Hope there will be a better way to work with Branch Protection some day...

@shtaif shtaif self-assigned this Sep 3, 2023
@shtaif shtaif force-pushed the try-to-fix-auto-release-failing-branch-protection branch from 24d3cf5 to 1d7567f Compare September 3, 2023 12:16
@shtaif shtaif changed the title Debug release workflow failing due to branch protection issues Fix release workflow failing due to branch protection issues Sep 3, 2023
@shtaif shtaif force-pushed the try-to-fix-auto-release-failing-branch-protection branch from 1d7567f to d0d6535 Compare September 3, 2023 12:18
@shtaif shtaif marked this pull request as ready for review September 3, 2023 12:21
@shtaif shtaif merged commit ad53271 into master Sep 3, 2023
6 checks passed
@shtaif shtaif deleted the try-to-fix-auto-release-failing-branch-protection branch September 3, 2023 12:23
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant