change to typescript implementation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shubh045
commented
Feb 29, 2024
| contractAddress, | ||
| NFT.abi, | ||
| signer | ||
| )as BaseContract as SuperCarERC1155;; |
There was a problem hiding this comment.
giving SuperERC1155 type to contract
AkulGaind
requested changes
Mar 4, 2024
| const [mintPrice, setMintPrice] = useState<number>(0); | ||
| const [burnPrice, setBurnPrice] = useState<number>(0); | ||
| const [nftBalance, setNftBalance] = useState<number>(0); | ||
| const contractAddress: string = "0x80f7f95Ef489C181656C6c9999402c59Fd1e4E46"; |
| try { | ||
| const signer = await provider.getSigner(); | ||
| const address = await signer.getAddress(); | ||
| const signer: ethers.JsonRpcSigner = await provider.getSigner(); |
There was a problem hiding this comment.
declare signer as a global variable do not declare it again and again
| const [mintPrice, setMintPrice] = useState<number>(0); | ||
| const [burnPrice, setBurnPrice] = useState<number>(0); | ||
| const [nftBalance, setNftBalance] = useState<number>(0); | ||
| const contractAddress: string = "0x80f7f95Ef489C181656C6c9999402c59Fd1e4E46"; | ||
|
|
||
| useEffect(() => { | ||
| setConnect(localStorage.getItem("address")); | ||
| }, []); |
There was a problem hiding this comment.
there are two useEffects with no dependencies, use only one
| toast("Account not connected!"); | ||
| return; | ||
| } | ||
| const errorMessage = error.message.split("(")[0]; | ||
| const error1 = error as Error; | ||
| const errorMessage: string = error1.message.split("(")[0]; |
There was a problem hiding this comment.
don't use 2 variables for a single error, try to use only one
| const signer = await provider.getSigner(); | ||
| const contract = new ethers.Contract(contractAddress, NFT.abi, signer); | ||
| const address = await signer.getAddress(); | ||
| const signer: ethers.JsonRpcSigner = await provider.getSigner(); |
There was a problem hiding this comment.
declare a global variable for signer
| setMintPrice(ethers.formatEther(Number(currentMintPrice).toString())); | ||
| setBurnPrice(ethers.formatEther(Number(prevMintPrice).toString())); | ||
| const currentMintPrice: number = Number(await contract.currentPrice()); | ||
| setMintPrice(Number(ethers.formatEther(currentMintPrice.toString()))); |
There was a problem hiding this comment.
why currentMintPrice has to be converted to string
|
|
||
| async function main() { | ||
|
|
||
| // const NFT = await hre.ethers.deployContract("NFT", ["Super Car", "SUP", hre.ethers.parseEther('0.02')]); | ||
| const NFT = await hre.ethers.deployContract("SuperCarERC1155", ["https://bafkreiebuhhy4e2p23nquu3llaftgvpy6cycpdfpuld7ccmfnksrzt2gom.ipfs.nftstorage.link/", 1000]); | ||
| const NFT = await ethers.deployContract("SuperCarERC1155", ["https://bafkreiebuhhy4e2p23nquu3llaftgvpy6cycpdfpuld7ccmfnksrzt2gom.ipfs.nftstorage.link/", 1000]); |
There was a problem hiding this comment.
get this link from env file
| import dotenv from 'dotenv'; | ||
| dotenv.config(); | ||
|
|
||
| let TESTNET_PRIVATE_KEY = process.env.TESTNET_PRIVATE_KEY as string; |
There was a problem hiding this comment.
Suggested change
| let TESTNET_PRIVATE_KEY = process.env.TESTNET_PRIVATE_KEY as string; | |
| const TESTNET_PRIVATE_KEY = process.env.TESTNET_PRIVATE_KEY as string; |
| dotenv.config(); | ||
|
|
||
| let TESTNET_PRIVATE_KEY = process.env.TESTNET_PRIVATE_KEY as string; | ||
| let SEPOLIA_TESTNET_RPC_URL = process.env.SEPOLIA_TESTNET_RPC_URL as string; |
There was a problem hiding this comment.
Suggested change
| let SEPOLIA_TESTNET_RPC_URL = process.env.SEPOLIA_TESTNET_RPC_URL as string; | |
| const SEPOLIA_TESTNET_RPC_URL = process.env.SEPOLIA_TESTNET_RPC_URL as string; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted Javascript part to typescript