Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cross env compatibility #31

Merged
merged 3 commits into from
May 18, 2023

Conversation

SzymonGalazka
Copy link
Contributor

@SzymonGalazka SzymonGalazka commented May 18, 2023

Currently, the library is not working on Windows, as Windows handles variable environments differently.
The issue is about the line:

"build:js": "NODE_ENV=production webpack build",

It has been checked on node versions 16.14.2 and 18.12.1.
Zrzut ekranu 2023-05-18 o 11 56 41
Introducing cross-env library as dev-dependency would solve that issue.

@SzymonGalazka SzymonGalazka changed the title Enable cross env commands Enable cross env compatibility May 18, 2023
@shubhamjain shubhamjain merged commit 831a17d into shubhamjain:main May 18, 2023
@shubhamjain
Copy link
Owner

Good change. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants