Support new middleware cookies api #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
promer94
requested changes
Jul 16, 2022
There was a problem hiding this comment.
Currently the preview is broken
https://nextra-theme-docs-dev-git-fork-huozhi-fix-next-middleware-api.vercel.sh/zh-CN
I think the reason is that
nextra/packages/nextra/src/locales.ts
Line 16 in 6d5c85e
fullUrl is different between next 12.1 and next 12.2
When user access https://swr.vercel.app/zh-CN
-
12.1
fullUrlwould behttps://swr.vercel.app/zh-CN/ -
12.2
fullUrlwould behttps://swr.vercel.app/zh-CN
It doesn't have trailing slash
dimaMachina
reviewed
Jul 16, 2022
test against actual api
promer94
approved these changes
Jul 17, 2022
1 task
1 task
tatukoivisto
pushed a commit
to tatukoivisto/nextra
that referenced
this pull request
Aug 20, 2023
* Support new middleware cookies api * update example * handle slashes * fix locale rewrites * extract locale for w/o trailing slash * fallback / * extract locale correctly * fix lock * update test snapshots * fix non index pages i18n * test: add locale middleware test * test against actual api test against actual api * fix locale Co-authored-by: Yixuan Xu <yixuanxu94@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-ref: vercel/swr-site#307 (comment)
rewrite the lcoale extracting from url logic, previously the pathname can be
/, then the url with host removed can bezh-CNorzh-CN/in with next version (12.2 vs 12.1). We'd better to find the first slash and get extract the locale from itThanks @promer94 for helping with setting up locale tests