Style improvements #811
Style improvements #811
Conversation
🦋 Changeset detectedLatest commit: fb874e7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@shuding for rtl jumps I have a better solution here https://github.com/shuding/nextra/pull/803/files#diff-8310a54b1ec9da38ed7c74e8c1328e33f07848d25bd9779811614642e3268747R180-R194 since now switch/theme popups will render in body via react portals, and they are not children for root div |
| .locale-switch[open] summary:before { | ||
| content: ' '; | ||
| content: ''; |
There was a problem hiding this comment.
this class (.locale-switch) seems not used anywhere, not?
There was a problem hiding this comment.
Oh right, that seems to be legacy
| @@ -181,6 +181,7 @@ const Details = ({ | |||
| <details | |||
| className="my-4 rounded border border-gray-200 bg-white p-2 shadow-sm dark:border-neutral-800 dark:bg-neutral-900 first:mt-0 last:mb-0" | |||
| {...props} | |||
| {...(openState && { 'data-expanded': true })} | |||
There was a problem hiding this comment.
data-expanded={openState} should works also
| "before:content-[''] before:inline-block before:transition-transform dark:before:invert", | ||
| '[[open]>&]:before:rotate-90 rtl:before:rotate-180' | ||
| "before:mr-1 before:content-[''] before:inline-block before:transition-transform dark:before:invert", | ||
| '[[data-expanded]>&]:before:rotate-90 rtl:before:rotate-180' |
There was a problem hiding this comment.
does previous didn't work? 🧐
There was a problem hiding this comment.
This makes sure that the arrow rotation animation isn’t delayed like the collapse animation
There was a problem hiding this comment.
Nice catch, remember that saw this issue :)
dev:theme-docsdon't trigger the v2 docs package100dvhis now outhrefdir=ltrmissing before hydration (layout jumps)