Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve argument types of initialize functions #25

Merged

Conversation

shun-shobon
Copy link
Contributor

@shun-shobon shun-shobon commented Mar 11, 2023

Although WebAssembly.instantiate() can accept BufferSource (ArrayBuffer | ArrayBufferView) and WebAssembly.Module, this library only accepts ArrayBuffer is the only one accepted. So I made it so that it accepts BufferSource and WebAssembly.Module with initYoga.
This may help with things like CF Workers where only compiled WASM is available.

ref:

@jeetiss jeetiss merged commit 58938fb into shuding:main Mar 12, 2023
@jeetiss
Copy link
Collaborator

jeetiss commented Mar 12, 2023

Thanks

@shun-shobon shun-shobon deleted the feature/support-compiled-webassembly branch March 12, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants