Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error after upgrading erlang 23 #30

Closed
romaluca opened this issue May 14, 2020 · 2 comments · Fixed by #31
Closed

Error after upgrading erlang 23 #30

romaluca opened this issue May 14, 2020 · 2 comments · Fixed by #31

Comments

@romaluca
Copy link

Hi this morning i upgrade erlang to 23 and fcmex return this error on execution of Fcmex.push:

09:00:42.633 [error] GenServer #PID<0.9388.0> terminating ** (FunctionClauseError) no function clause matching in Fcmex.Util.parse_result/1 (fcmex 0.3.2) lib/util.ex:12: Fcmex.Util.parse_result({:error, %HTTPoison.Error{id: nil, reason: {:options, {:sslv3, {:versions, [:"tlsv1.2", :"tlsv1.1", :tlsv1, :sslv3]}}}}}) (flow 1.0.0) lib/flow/materialize.ex:731: anonymous fn/4 in Flow.Materialize.mapper/2 (flow 1.0.0) lib/flow/materialize.ex:699: Flow.Materialize."-mapper_ops/1-lists^foldl/2-0-"/3 (flow 1.0.0) lib/flow/materialize.ex:699: anonymous fn/5 in Flow.Materialize.mapper_ops/1 (flow 1.0.0) lib/flow/map_reducer.ex:59: Flow.MapReducer.handle_events/3 (gen_stage 1.0.0) lib/gen_stage.ex:2395: GenStage.consumer_dispatch/6 (gen_stage 1.0.0) lib/gen_stage.ex:2574: GenStage.take_pc_events/3 (stdlib 3.13) gen_server.erl:680: :gen_server.try_dispatch/4 (stdlib 3.13) gen_server.erl:756: :gen_server.handle_msg/6 (stdlib 3.13) proc_lib.erl:226: :proc_lib.init_p_do_apply/3 Last message: {:"$gen_consumer", {#PID<0.9387.0>, #Reference<0.3834918260.1681915906.212152>}, [%{to: ["234324234234234231"]}]} 09:00:42.637 [error] ** (exit) exited in: GenStage.close_stream(%{}) ** (EXIT) an exception was raised: ** (FunctionClauseError) no function clause matching in Fcmex.Util.parse_result/1 (fcmex 0.3.2) lib/util.ex:12: Fcmex.Util.parse_result({:error, %HTTPoison.Error{id: nil, reason: {:options, {:sslv3, {:versions, [:"tlsv1.2", :"tlsv1.1", :tlsv1, :sslv3]}}}}}) (flow 1.0.0) lib/flow/materialize.ex:731: anonymous fn/4 in Flow.Materialize.mapper/2 (flow 1.0.0) lib/flow/materialize.ex:699: Flow.Materialize."-mapper_ops/1-lists^foldl/2-0-"/3 (flow 1.0.0) lib/flow/materialize.ex:699: anonymous fn/5 in Flow.Materialize.mapper_ops/1 (flow 1.0.0) lib/flow/map_reducer.ex:59: Flow.MapReducer.handle_events/3 (gen_stage 1.0.0) lib/gen_stage.ex:2395: GenStage.consumer_dispatch/6 (gen_stage 1.0.0) lib/gen_stage.ex:2574: GenStage.take_pc_events/3 (stdlib 3.13) gen_server.erl:680: :gen_server.try_dispatch/4 (stdlib 3.13) gen_server.erl:756: :gen_server.handle_msg/6 (stdlib 3.13) proc_lib.erl:226: :proc_lib.init_p_do_apply/3 (gen_stage 1.0.0) lib/gen_stage/stream.ex:160: GenStage.Stream.close_stream/1 (elixir 1.10.3) lib/stream.ex:1415: Stream.do_resource/5 (elixir 1.10.3) lib/enum.ex:3383: Enum.reverse/1 (elixir 1.10.3) lib/enum.ex:2982: Enum.to_list/1 (shuttertop 0.3.1) lib/shuttertop/fcm/pusher_http.ex:9

@romaluca romaluca changed the title Error after upgrade to erlang 23 Error after upgrading erlang 23 May 14, 2020
@shufo
Copy link
Owner

shufo commented May 15, 2020

@romaluca
Thanks for reporting issue!

It seems parse result function occurs error because HTTPoison used in this lib detects some error

Fcmex.Util.parse_result/1 (fcmex 0.3.2) lib/util.ex:12: Fcmex.Util.parse_result({:error, %HTTPoison.Error{id: nil, reason: {:options, {:sslv3, {:versions, [:"tlsv1.2", :"tlsv1.1", :tlsv1, :sslv3]}}}}}) 

adding HTTPoison error handling would be resolve this issue.
I'll add this error handling on this weekend. thanks!

shufo added a commit that referenced this issue May 17, 2020
@shufo shufo closed this as completed in #31 May 17, 2020
shufo added a commit that referenced this issue May 17, 2020
@shufo
Copy link
Owner

shufo commented May 17, 2020

published 0.3.3 with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants