Update README.md #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the hex dep version. As well I updated the topic send example since for sending a message to a topics it's required the following format `/topics/$topic` (see https://firebase.google.com/docs/cloud-messaging/http-server-ref) As a suggestion, I would consider validating the correct format and five user info about this error, since the one from Google it's not clear enough (returns an error `%{"error" => "InvalidRegistration"}`). Or even I would consider prepending the `/topics/` string to the given one if does not match the required format.
|
Thanks for updating README!
According to your suggestion, I will try to verify the topic name so that it returns a tuple like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the hex dep version.
As well I updated the topic send example since for sending a message to a topics it's required the following format
/topics/$topicAs a suggestion, I would consider validating the correct format and five user info about this error, since the one from Google it's not clear enough (returns an error
%{"error" => "InvalidRegistration"}). Or even I would consider prepending the/topics/string to the given one if does not match the required format.