blockSelf over-retains self

[hlung]

In ATSDragToReorderTableViewController.m, self got retained when blockSelf is accessed in block, thus self is never deallocated (ARC).

- (void)viewDidLoad {
[super viewDidLoad];

if ( reorderingEnabled )
    [self establishGestures];


/*
 *  If app resigns active while we're dragging, safely complete the drag.
 */
__block ATSDragToReorderTableViewController *blockSelf = self; // self got retained when blockSelf is accessed in block, thus self is never deallocated (ARC)

resignActiveObserver = [[NSNotificationCenter defaultCenter] addObserverForName:UIApplicationWillResignActiveNotification object:nil queue:nil usingBlock:^(NSNotification *arg1) {
    if ( [blockSelf isDraggingCell] ) {
        CGPoint currentPoint = [blockSelf->dragGesture translationInView:blockSelf.tableView];
        [blockSelf fastCompleteGesturesWithTranslationPoint:currentPoint];
    }
}];
}

[hlung]

Solved. Use observer with selector instead of a block.

[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(doResignActive) name:UIApplicationWillResignActiveNotification object:nil];

- (void)doResignActive {
if ( [self isDraggingCell] ) {
    CGPoint currentPoint = [self->dragGesture translationInView:self.tableView];
    [self fastCompleteGesturesWithTranslationPoint:currentPoint];
}
}