Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error propagation for kinesis send errors #2

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

huntharo
Copy link
Contributor

@huntharo huntharo commented May 16, 2024

  • Errors thrown by KinesisClient.send were being hidden in an error collection that could not be accessed by the caller
  • Add unit tests for this type of error
  • Fix the error propagation
  • Note: this is NOT the same as a throttled write within a batch, which does not throw an error but marks specified records in the result as having failed

Copy link

📊 Node.js Code Coverage Report

File Lines Lines Hit / Found Uncovered Lines Branches
src/kinesis-background-writer.ts ✅ 100.0% 137 / 137 0 100.0%
src/kinesis-retrier.ts ✅ 94.6% 210 / 222 12 77.8%
Overall ✅ 96.7% 347 / 359 12 82.8%

@huntharo huntharo changed the title Add tests for error propagation and fix kinesis send invoke errors fix: Add tests for error propagation and fix kinesis send invoke errors May 16, 2024
@huntharo huntharo changed the title fix: Add tests for error propagation and fix kinesis send invoke errors fix: Error propagation for kinesis send errors May 16, 2024
@huntharo huntharo merged commit 49c5d2a into main May 16, 2024
3 checks passed
@huntharo huntharo deleted the error-propagation branch May 16, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant