Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update profile list on character change #200

Merged
merged 10 commits into from
May 27, 2023

Conversation

bharathkalyans
Copy link
Contributor

Description

  • Called the handleSearch function inside the handleInoutChange function so that we can continuously update the profiles list giving the user a better experience.

Related Issues

Changes Proposed

const handleInputChange = (event) => {
    setSearchValue(event.target.value);
    handleSearch(); //Added this function
  };

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • I have updated the documentation to reflect the changes I've made.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Feature.mov

Note to reviewers

@vercel
Copy link

vercel bot commented May 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2023 11:23am

@shyamtawli
Copy link
Owner

@bharathkalyans With the latest changes we have done I think is lagging on my side when searching done. Can you confirm it?

@bharathkalyans
Copy link
Contributor Author

@bharathkalyans With the latest changes we have done I think is lagging on my side when searching done. Can you confirm it?

  • Looks fine in the deployed preview right?

@shyamtawli
Copy link
Owner

@bharathkalyans With the latest changes we have done I think is lagging on my side when searching done. Can you confirm it?

  • Looks fine in the deployed preview right?

Yeah, but when I am searching it lagging on my side. Can you check the deployment above.

@bharathkalyans
Copy link
Contributor Author

  • Yeah the page is hanging sometimes.
  • Probably due to the wrong updation of the states.

@shyamtawli
Copy link
Owner

@bharathkalyans Let me find a way to resolve that. Do you have any solution?

@shyamtawli shyamtawli added enhancement New feature or request feature New Feature labels May 24, 2023
@shyamtawli shyamtawli changed the title feat: Adds the feature for issue #199 feat: update profile list on character change May 24, 2023
@bharathkalyans
Copy link
Contributor Author

  • Have a look at this 👉🏻 : stackoverflow answer
  • I think there is a problem with the rendering which is making the page laggy!
  • I guess it's not the best way to update the profiles list on every key click!

@shyamtawli
Copy link
Owner

@bharathkalyans What about saving profile data in localstorage first and then searching?

@bharathkalyans
Copy link
Contributor Author

@bharathkalyans What about saving profile data in localstorage first and then searching?

  • We can do that for now, once in the future if we migrate to a remote database it becomes easier.

@shyamtawli
Copy link
Owner

@bharathkalyans What about saving profile data in localstorage first and then searching?

  • We can do that for now, once in the future if we migrate to a remote database it becomes easier.

Lets try it and see the lagging stops or not after saving it in localstorage on client side.
Yeah we will do many things in future.

CameronSquires and others added 6 commits May 26, 2023 18:54
* add: Bharath Kalyan S

* Updated the bharathkalyans.json

---------

Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
* Added hovering effect to Social media icons

* made the required changes in the top and left margin

---------

Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
@bharathkalyans
Copy link
Contributor Author

bharathkalyans commented May 26, 2023

@shyamtawli This PR fixes the lagging issue!
And sorry I had to pull the latest changes from the master to the branch which was lagging behind of many commits.

@shyamtawli shyamtawli merged commit 5619150 into shyamtawli:master May 27, 2023
3 checks passed
@shyamtawli
Copy link
Owner

@bharathkalyans Thanks for the Contribution and helping to improve project.

@bharathkalyans
Copy link
Contributor Author

@shyamtawli Let me know if you need a project maintainer! Will be happy to work on it 🙌🏼.

@shyamtawli
Copy link
Owner

Thank you for that, @bharathkalyans Currently, I can handle it myself. If in the future I need assistance, I will definitely contact you to be a maintainer of the project..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants