Feature: Support observables for label translations #466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facilitate the integration of label translations by allowing the use of
Observable
. This feature allows integration with otherasynchronous services like ngx-translate or other asynchronous APIs.
This PR contains:
Breaking Changes?
Checklist
Describe Your Changes
Add the ability to provide label translation using
string
orObservable
to avoid overwriting NgxEditorConfig when language update is needed. By supportingObservable
, labels can be translated more easily with modules like ngx-translate. Example of implementation withngx-translate
:Does this PR affects any existing issues?
This feature can solve this issue #451 which allows you to manage different languages and update labels without the need to refresh the page or overwrite the editor's configuration manually when display language is updated.