Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.0 #72

Merged
merged 4 commits into from
Nov 21, 2017
Merged

Release 3.0 #72

merged 4 commits into from
Nov 21, 2017

Conversation

ku1ik
Copy link
Owner

@ku1ik ku1ik commented Oct 24, 2017

Branch for last pre-release fixes. As this is major release we can look for some stuff to change. I don't see anything else other than what I updated in these few commits.

Do you have anything to add here @olleolleolle ? I added you as author to gemspec as you're the maintainer. Feel free to revert if you don't like it.

@olleolleolle
Copy link
Collaborator

@sickill Thanks for adding my name to the credits list. I'm OK with it. I'm a maintainer, so we're 2 now.

@ku1ik
Copy link
Owner Author

ku1ik commented Oct 24, 2017

Yes, I often mistake the for a ;)

@olleolleolle
Copy link
Collaborator

@sickill Now, if we're targetting 2.1+, we have support for Refinements. Then, the Refinements PR could be brushed up and added.

@ku1ik
Copy link
Owner Author

ku1ik commented Oct 24, 2017

Aha, that's good idea!

@ku1ik
Copy link
Owner Author

ku1ik commented Nov 4, 2017

Also realized that having refinements we can drop the legacy String mixin support completely.

@olleolleolle
Copy link
Collaborator

@sickill Would it be right to drop in the Refinements thing now (during a major update), and force people to change their usage, or is that a lot to ask of people which depend on this library? (The cost of being popular: can't change. "Avoid success at all costs" --Simon Peyton Jones)

@ku1ik
Copy link
Owner Author

ku1ik commented Nov 13, 2017

Hmm, good point about popularity. It's not harmful to keep the old String mixin. What we could do:

  • add refinements in 3.0
  • keep the mixin in 3.x line, so it works for existing codebases, but remove it from README now so new people only use refinements
  • remove mixin in 4.0

Sounds good?

@olleolleolle
Copy link
Collaborator

@sickill That sounds prudent, 👍

@ku1ik ku1ik merged commit e031de8 into master Nov 21, 2017
@olleolleolle olleolleolle deleted the release-3-0 branch November 21, 2017 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants