-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.0 #72
Release 3.0 #72
Conversation
@sickill Thanks for adding my name to the credits list. I'm OK with it. I'm a maintainer, so we're 2 now. |
Yes, I often mistake |
@sickill Now, if we're targetting 2.1+, we have support for Refinements. Then, the Refinements PR could be brushed up and added. |
Aha, that's good idea! |
Also realized that having refinements we can drop the legacy String mixin support completely. |
@sickill Would it be right to drop in the Refinements thing now (during a major update), and force people to change their usage, or is that a lot to ask of people which depend on this library? (The cost of being popular: can't change. "Avoid success at all costs" --Simon Peyton Jones) |
Hmm, good point about popularity. It's not harmful to keep the old String mixin. What we could do:
Sounds good? |
@sickill That sounds prudent, 👍 |
Branch for last pre-release fixes. As this is major release we can look for some stuff to change. I don't see anything else other than what I updated in these few commits.
Do you have anything to add here @olleolleolle ? I added you as author to gemspec as you're the maintainer. Feel free to revert if you don't like it.