Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dependencies] js:eval error & download link invalid. #36

Closed
wants to merge 1 commit into from

Conversation

AntiKnot
Copy link

Purpose

Resolves #35

Goals

  • fix siddhi-tooling-base build failed
  • fix js:eval error

Approach

  • update openjdk image version
  • update apache-ant download link
  • update apache-ant version from 1.10.6 -> 1.10.12

User stories

issues #32 and pr #33
After referring to these, I realized that the reason may be openjdk docker image, and found effective links while repairing.

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

#35

Training

#35

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

#32

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested
JDK: docker image adoptopenjdk/openjdk8:jdk8u312-b07
database: docker mysql:5.7
browser: Google Chrome Version 95.0.4638.69 (Official Build) (x86_64)

Learning

#32
#33
https://siddhi.io/en/v5.1/download/#512
https://ant.apache.org/bindownload.cgi
https://stackoverflow.com/a/24326540
https://siddhi-io.github.io/siddhi-map-json/

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2021

CLA assistant check
All committers have signed the CLA.

@AntiKnot AntiKnot changed the title [fix] js:eval error & download link invalid. [dependencies] js:eval error & download link invalid. Nov 25, 2021
@AntiKnot AntiKnot closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dependencies] js:eval error & link invalid
2 participants