Adding archetype for Siddhi extensions #1
Conversation
|
|
||
| ``` | ||
| <dependency> | ||
| <groupId>org.wso2.extension.siddhi.io.</groupId> |
There was a problem hiding this comment.
Fixed in 624c01a
|
|
||
| ``` | ||
| <dependency> | ||
| <groupId>org.wso2.extension.siddhi.io.</groupId> |
There was a problem hiding this comment.
io should be changed to execution
There was a problem hiding this comment.
Fixed in 624c01a
| package ${package}.${executionTypeinLowerCase}.streamprocessor; | ||
|
|
||
| public class TestCaseOf${classNameOfStreamProcessor} { | ||
| } |
There was a problem hiding this comment.
Fixed in 624c01a
| * name = "The name of the extension", | ||
| * namespace = "The namespace of the extension", | ||
| * description = "The description of the extension (optional).", | ||
| * //Sink configurations |
There was a problem hiding this comment.
this is not sink. Check all other places where this comment is used
There was a problem hiding this comment.
Fixed in 624c01a
| ``` | ||
| <dependency> | ||
| <groupId>org.wso2.extension.siddhi.io.</groupId> | ||
| <artifactId>siddhi-io-</artifactId> |
There was a problem hiding this comment.
io should be replaced by map
There was a problem hiding this comment.
Fixed in 624c01a
| * name = "The name of the extension", | ||
| * namespace = "The namespace of the extension", | ||
| * description = "The description of the extension (optional).", | ||
| * //Sink configurations |
There was a problem hiding this comment.
sink mapper configs. Check all other places
There was a problem hiding this comment.
Fixed in 624c01a
|
|
||
| ``` | ||
| <dependency> | ||
| <groupId>org.wso2.extension.siddhi.io.</groupId> |
There was a problem hiding this comment.
Fixed in 624c01a
| </plugins> | ||
| </pluginManagement> | ||
| </build> | ||
| </project> |
There was a problem hiding this comment.
Please add a new line at the end of each file. Please correct in all the palces
There was a problem hiding this comment.
Fixed in #12
| <extension> | ||
| <groupId>org.apache.maven.archetype</groupId> | ||
| <artifactId>archetype-packaging</artifactId> | ||
| <version>3.0.1</version> |
There was a problem hiding this comment.
Normal practice is to add version as properties to parent pom and refer that here. Can't we use the same here?
There was a problem hiding this comment.
Fixed in #12
| @@ -0,0 +1,117 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
According to the code review comment, all files under the archetype-resources folder don't need to put the license header. Because these files are a resource for generating the project using the archetype. Hence I didn't put the license header.
| @@ -0,0 +1,109 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
According to the code review comment, all files under the archetype-resources folder don't need to put the license header. Because these files are a resource for generating the project using the archetype. Hence I didn't put the license header.
| @@ -0,0 +1,10 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
license header? Please correct in all the places
There was a problem hiding this comment.
According to the code review comment, all files under the archetype-resources folder don't need to put the license header. Because these files are a resource for generating the project using the archetype. Hence I didn't put the license header.
No description provided.