Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve operator crash when NATS unavailable #51

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

BuddhiWathsala
Copy link
Contributor

Purpose

Resolve #50. As minor changes resolve HTTP status code showing and remove unwanted specs in parser YAML.

Approach

The error throw of the watch function ignored instead of returning it. Do not use any error logging or notification since in the controller runtime by default shows the error. Here we resolve the operator crashing problem. But the operator will show the error of missing NATS because that error log is not in the operator scope.

Test environment

minikube 0.33.1

@mohanvive mohanvive merged commit 9414346 into siddhi-io:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator crashes the when NATS unavailable in the cluster
2 participants