Change persistentVolume spec to persistentVolumeClaim and change samples #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Refactor
persistentVolumetopersistentVolumeClaimin Siddhi CRDGoals
Within the Siddhi Operator,
persistentVolumespec of Siddhi CRD is being used to create the PVCs. Hence, refactoring the naming topersistentVolumeClaim.Approach
Change the SiddhiProcess spec and use default
corev1.PersistentVolumeClaimSpecas the mapping object. From that, we can directly map the user given entries to the PVC struct.Also, change the specs of the sample to use
persistentVolumeClaim. The samples contained an unused environmental variable BASIC_AUTH_ENABLED. So add use that env inside each Siddhi app sample.Samples
deploy/examples
Related PRs
#34
Related Issues
#82
Test environment
minikube version: v1.2.0