Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the right package manager in ci #20

Merged
merged 3 commits into from
Mar 6, 2023

Conversation

mahdiboomeri
Copy link
Contributor

Currently, when using package managers other than npm, ci fails
example:

npm ERR! The `npm ci` command can only install with an existing package-lock.json or
npm ERR! npm-shrinkwrap.json with lockfileVersion >= 1. Run an install with npm@5 or
npm ERR! later to generate a package-lock.json file, then try again.

This PR uses https://github.com/antfu/ni to select the appropriate package manager.

@BracketJohn
Copy link
Contributor

Great contribution, thanks @mahdiboomeri ❤️

Let's merge this wen CI goes through (:

@BracketJohn
Copy link
Contributor

BracketJohn commented Mar 6, 2023

@mahdiboomeri can you checkout the CI failing? It's our smoke-detector check that tests whether the app starts + allows a status 200 curl (:

edit: seems to be a more general problem, I'm also looking into it in #21

@BracketJohn BracketJohn merged commit ad7dcc6 into sidebase:main Mar 6, 2023
@mahdiboomeri
Copy link
Contributor Author

Hey @BracketJohn , Sorry i was away. Thanks for fixing the issue 💚

@mahdiboomeri mahdiboomeri deleted the fix/ci branch March 6, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants