Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish NUXT_AUTH_ORIGIN logic #848

Closed
2 tasks done
phoenix-ru opened this issue Aug 8, 2024 · 0 comments
Closed
2 tasks done

Polish NUXT_AUTH_ORIGIN logic #848

phoenix-ru opened this issue Aug 8, 2024 · 0 comments
Labels
enhancement An improvement that needs to be added

Comments

@phoenix-ru
Copy link
Collaborator

phoenix-ru commented Aug 8, 2024 •
edited
Loading

Follow up on #837

          Does not need to be done in this PR. but as a follow-up let's:
  • Adapt the ~/playground-* to use NUXT_AUTH_ORIGIN
  • Adapt any starter to use NUXT_AUTH_ORIGIN
  • Adapt the nuxt-auth-example to use NUXT_AUTH_ORIGIN

Originally posted by @zoey-kaiser in #837 (review)

Additionally:

  • Change default originEnvKey to NUXT_AUTH_ORIGIN and automatically strip NUXT_ prefix for camel-case config keys
  • Check type of variable from config to be string | undefined - report error otherwise
@phoenix-ru phoenix-ru added the enhancement An improvement that needs to be added label Aug 8, 2024
@phoenix-ru phoenix-ru changed the title Follow up on #837 Polish NUXT_AUTH_ORIGIN logic Aug 8, 2024
phoenix-ru added a commit that referenced this issue Aug 8, 2024
@phoenix-ru
feat(#673, #811, #848): back-port authjs migration
93e96be
@phoenix-ru phoenix-ru mentioned this issue Aug 8, 2024
Merged
9 tasks
zoey-kaiser added a commit that referenced this issue Aug 20, 2024
@phoenix-ru @zoey-kaiser
feat(#673, #523, #848): back-port authjs migration (#849)
355e865 
Co-authored-by: Zoey <zoeykaiser8@gmail.com>
@phoenix-ru phoenix-ru mentioned this issue Sep 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An improvement that needs to be added
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phoenix-ru @zoey-kaiser