feat: make origin configurable at runtime #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoey-kaiser
requested changes
Jan 4, 2023
| @@ -18,6 +18,11 @@ let preparedAuthHandler: ReturnType<typeof eventHandler> | undefined | |||
| let usedSecret: string | undefined | |||
| const SUPPORTED_ACTIONS: NextAuthAction[] = ['providers', 'session', 'csrf', 'signin', 'signout', 'callback', 'verify-request', 'error', '_log'] | |||
|
|
|||
| export const ERROR_MESSAGES = { | |||
There was a problem hiding this comment.
One feedback I got from the streamer using nuxt-auth for the first time was that our error messages were pretty long and spammed the console.
Do we maybe want to shorten them here and have a dedicated part of our docs list fixes for each error? Then we can link that page in the error message and go more into detail into what the issue is?
eg:
There was a problem hiding this comment.
Super idea! I've added it (:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
originconfigurable at runtime viaAUTH_ORIGINsecretat build time