This repository has been archived by the owner on Dec 12, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 20
Add saveUninitialized option #41
Open
interpretor
wants to merge
8
commits into
sidebase:main
Choose a base branch
from
interpretor:add-saveuninitialized-option
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add saveUninitialized option #41
interpretor
wants to merge
8
commits into
sidebase:main
from
interpretor:add-saveuninitialized-option
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interpretor
force-pushed
the
add-saveuninitialized-option
branch
from
November 27, 2022 22:21
ba1b297
to
a34d5d8
Compare
- Move newSessionIfModified logic to dedicated method - Use deep equal comparison to watch changes of the context session
interpretor
commented
Dec 5, 2022
session = await newSession(event) | ||
} else { | ||
// 1. Create an empty session object in the event context | ||
event.context.session = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forces a session that is "uninitialized" to be saved to the store. A session is uninitialized when it is new but not modified. Choosing
false
is useful for implementing login sessions, reducing server storage usage, or complying with laws that require permission before setting a cookie.The default is
true
, as it has been before, so it shouldn't affect the current behavior of the middleware. The option should behave similar to the saveUninitialized option inexpress-session
.Implementing this has been a bit tricky. The idea was to get a listener to the
event.context.session
server object, which creates a session when the object has been modified and therefore sends a cookie to the client. I'm not aware of any listener which gets called when every event handler is finished, so I built a proxy for theres.end()
method to get a hook to the very end of all event listeners.The proxy is only in use when setting
saveUninitialized = false
.