test: add integration test for variables and Sprig template funcs #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
commented
Nov 18, 2019
| @@ -54,4 +55,4 @@ frontend: | |||
|
|
|||
| .PHONY: integration | |||
| integration: integration.test bldr | |||
| cd internal/pkg/integration && PATH="$$PWD/../../../out:$$PATH" integration.test -test.v | |||
| cd internal/pkg/integration && PATH="$$PWD/../../../out:$$PATH" integration.test -test.v -test.run $(RUN_TESTS) | |||
There was a problem hiding this comment.
this allows to run subset of the tests, e.g.:
make integration RUN_TESTS=TestIntegration/variables/docker
Unit test name includes both test folder (variables) and runner type (docker), so we can limit the scope in a pretty efficient way.
This adds new integration test for variables of different kinds. As working for the test I realized `text/template` is too limited to do sometimes useful templating, so I pulled in popular (used in Helm) set of template functions Sprig: http://masterminds.github.io/sprig/ Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
smira
force-pushed
the
moar-integration-tests
branch
from
89952f3
to
cfa6684
Compare
andrewrynhard
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new integration test for variables of different kinds. As
working for the test I realized
text/templateis too limited to dosometimes useful templating, so I pulled in popular (used in Helm) set
of template functions Sprig: http://masterminds.github.io/sprig/
Signed-off-by: Andrey Smirnov smirnov.andrey@gmail.com