fix: drop the LVM2 udev lvm rule #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule depends on `systemd-run`, and it won't work in Talos anyways, but it conflicts with Talos activating LVM volumes, as the call to `pvscan` updates the cache as if the volume got already activated, while in fact it hasn't been activated yet. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
dsseng
previously requested changes
Oct 2, 2024
| @@ -99,6 +99,9 @@ steps: | |||
| install: | |||
| - | | |||
| make DESTDIR=/rootfs install | |||
|
|
|||
| # LVM activation is handled by Talos itself | |||
| rm -f /rootfs/usr/lib/udev/rules.d/69-dm-lvm.rules | |||
There was a problem hiding this comment.
Isn't https://github.com/lvmteam/lvm2/blob/main/udev/95-dm-notify.rules.in also unnecessary? We seem not to have dmsetup in our rootfs if I'm not mistaken
There was a problem hiding this comment.
probably, but I don't want to make bigger changes, as this is going to be backported to 1.8 - so the minimal changes required
dsseng
approved these changes
Oct 2, 2024
|
/m |
smira
added a commit
to smira/talos
that referenced
this pull request
Oct 2, 2024
Two fixes were in pkgs/lvm2: * siderolabs/pkgs#1041 * siderolabs/pkgs#1042 Other fixes in this PR: * drop the dm-raid patch, `lvm2` loads the required kernel modules on its own * adjust the controller a bit for some interactions * make Rook test use more complicated, encrypted setup which uses LVM * adjust LVM test to handle a case when there's more than one worker Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Oct 2, 2024
Two fixes were in pkgs/lvm2: * siderolabs/pkgs#1041 * siderolabs/pkgs#1042 Other fixes in this PR: * drop the dm-raid patch, `lvm2` loads the required kernel modules on its own * adjust the controller a bit for some interactions * make Rook test use more complicated, encrypted setup which uses LVM * adjust LVM test to handle a case when there's more than one worker Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Oct 3, 2024
Two fixes were in pkgs/lvm2: * siderolabs/pkgs#1041 * siderolabs/pkgs#1042 Other fixes in this PR: * adjust the controller a bit for some interactions * make Rook test use more complicated, encrypted setup which uses LVM * adjust LVM test to handle a case when there's more than one worker Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Merged
smira
added a commit
to smira/talos
that referenced
this pull request
Oct 8, 2024
Two fixes were in pkgs/lvm2: * siderolabs/pkgs#1041 * siderolabs/pkgs#1042 Other fixes in this PR: * adjust the controller a bit for some interactions * make Rook test use more complicated, encrypted setup which uses LVM * adjust LVM test to handle a case when there's more than one worker Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit 7486157)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule depends on
systemd-run, and it won't work in Talos anyways, but it conflicts with Talos activating LVM volumes, as the call topvscanupdates the cache as if the volume got already activated, while in fact it hasn't been activated yet.