🐛 interactive installer hangs if terminal type is unsupported #8205
Assignees
Comments
nberlee
changed the title
smira
changed the title
smira
added a commit
to smira/talos
that referenced
this issue
Jan 31, 2024
In the previous implementation, even though `installer.err` was set, it was never checked 🤦. The run loop was stolen from the dashboard code. Fixes siderolabs#8205 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this issue
Feb 1, 2024
In the previous implementation, even though `installer.err` was set, it was never checked 🤦. The run loop was stolen from the dashboard code. Fixes siderolabs#8205 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit 593afee)
smira
added a commit
to smira/talos
that referenced
this issue
Feb 1, 2024
In the previous implementation, even though `installer.err` was set, it was never checked 🤦. The run loop was stolen from the dashboard code. Fixes siderolabs#8205 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit 593afee)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug Report
When TERM is set to an unsupported value, talosctl apply-config --mode interactive will hang.
Description
My Terminal sets TERM=alacritty, when running talosctl dashboard it cleanly errors out with
terminal type unsupported, which reminds me to set TERM to linux. However, when I use talosct apply-config --mode interactive with an unsupported terminal it will just hang.I would prefer to be reminded that its actually my fault that is not working, just like dashboard, instead of thinking I have a connection problem.
Logs
Environment
The text was updated successfully, but these errors were encountered: