feat: add host dns support for resolving member addrs #8610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyMV
force-pushed
the
node-dns
branch
2 times, most recently
from
19dbb59
to
51c2f4b
Compare
|
Okay, I went this way: > sudo -E talosctl cluster create \
--provisioner=qemu \
--cidr=172.20.0.0/24 \
...
--controlplanes 1 \
--workers 1 \
--config-patch=@./patch.yamlWith version: v1alpha1
machine:
features:
hostDNS:
enabled: true
forwardKubeDNSToHost: true
resolveMemberNames: trueThen > kubectl run alpine --image alpine -it -- ashThen > ping talos-default-controlplane-1And result is: 🎉 |
DmitriyMV
commented
Apr 18, 2024
internal/app/machined/pkg/controllers/network/dns_resolve_cache.go
Outdated
Show resolved
Hide resolved
smira
reviewed
Apr 18, 2024
internal/app/machined/pkg/controllers/network/dns_resolve_cache.go
Outdated
Show resolved
Hide resolved
internal/app/machined/pkg/controllers/network/dns_resolve_cache.go
Outdated
Show resolved
Hide resolved
smira
reviewed
Apr 18, 2024
internal/app/machined/pkg/controllers/network/dns_resolve_cache.go
Outdated
Show resolved
Hide resolved
smira
approved these changes
Apr 18, 2024
Closes siderolabs#8330 Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
|
/m |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8330