fix: fix graph diffs in dashboard when node aliases are used #9099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
reviewed
Aug 2, 2024
| @@ -18,6 +18,11 @@ type Data struct { | |||
| // Data per each node. | |||
| Nodes map[string]*Node | |||
|
|
|||
| // UnresolvedNodes contain the same Node data as Nodes | |||
There was a problem hiding this comment.
is this some kind of a race that we resolve after the graphs start working?
There was a problem hiding this comment.
Nope, it wasn't a race, the comparison was done wrongly in a consistent way. So when a node alias (name etc.) was used, the graphs were never updating. it went unnoticed.
Also, I now solved the issue in a different way, so this code is no more there.
utkuozdemir
force-pushed
the
fix-dashboard-perf-graphs
branch
from
c8c83d4
to
cea633c
Compare
smira
approved these changes
Aug 7, 2024
When `talosctl dashboard` is used with node "aliases" (e.g., node names or machine IDs in Omni) passed via `-n` flag, the graphs in the monitor tab were not rendered correctly: The matching of the old and current data were done incorrectly. Fix this by pushing node alias->IP resolution down to the (api & log) data sources of the dashboard, by passing a resolver to them. Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
utkuozdemir
force-pushed
the
fix-dashboard-perf-graphs
branch
from
cea633c
to
9d34158
Compare
|
/m |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
talosctl dashboardis used with node "aliases" (e.g., node names or machine IDs in Omni) passed via-nflag, the graphs in the monitor tab were not rendered correctly: The matching of the old and current data were done incorrectly.Fix this by doing the comparison over the non-resolved node names, not over the resolved ones.