Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add policycoreutils for building squashfs with SELinux #382

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

dsseng
Copy link
Member

@dsseng dsseng commented Aug 25, 2024

Only install setfiles, add libselinux as a dependency

Pkgfile Outdated
@@ -178,6 +178,11 @@ vars:
libnl_sha256: 9fe43ccbeeea72c653bdcf8c93332583135cda46a79507bfd0a483bb57f65939
libnl_sha512: 80fbbc079299c90afd2a5eda62e4d4f98bf4ef23958c3ce5101f4ed4d81d783af733213bb3bab15f218555d8460bc2394898f909f4ac024fc27281faec86a041

# renovate: datasource=git-tags depName=SELinuxProject/selinux
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess we can just define one selinux version, since we re-use the same tarball everywhere? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the tarball, but tag. Perhaps will do so

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while at this, also could you update this back to just https://github.com/siderolabs/tools/blob/main/.github/renovate.json#L40 SELinuxProject/selinux

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are hashes handled by us, not Renovate? Is Renovate just for notification purposes? Since if I make hash names different from the version name it might become unhappy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renovate is just notification, we still handle hashes, one day we can handle it ourselves

@dsseng dsseng force-pushed the setfiles branch 2 times, most recently from 37c0090 to 67718b2 Compare August 26, 2024 08:31
Only install setfiles, add libselinux as a dependency

Also unify the version for all SELinux userspace components

Signed-off-by: Dmitry Sharshakov <dmitry.sharshakov@siderolabs.com>
@dsseng
Copy link
Member Author

dsseng commented Aug 26, 2024

/m

@talos-bot talos-bot merged commit 2b8dab4 into siderolabs:main Aug 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants