Allow PKCS#8 private keys in .pem files

[jameshfisher]

No description provided.

[jameshfisher]

This should fix #100

[jameshfisher]

To add some more context, we use sideshow/apns2 internally at Pusher, and we've experienced issues with some customers' openssl versions generating .pem files with PKCS#8 private keys. pusher/libPusher#257

[coveralls]

Coverage increased (+0.09%) to 91.753% when pulling 868878c on jameshfisher:parse-pkcs8 into cf826c6 on sideshow:master.

[jameshfisher]

@sideshow WDYT?

[SimpleApp]

@sideshow Is there something wrong with that pull request ? I confirm that the "regular" method for creating a PEM from Keychain, using openssl , creates PEM files that are unusable by this library. I also pulled @jameshfisher fork, and it solves the bug. I think it's quite a critical bug.

[sideshow]

Sorry @jameshfisher @SimpleApp for not taking a look at this sooner.
It looks awesome, thanks so much for the contribution!

I had seen this problem before with different versions of open SSL. Can you guys confirm exactly which version you are running? Looking forward to merging this.

[jameshfisher]

@sideshow I've seen it with at least two different versions of OpenSSL:

$ openssl version  # MacOS, which uses the LibreSSL fork
LibreSSL 2.2.7

$ openssl version  # on Ubuntu 14.04
OpenSSL 1.0.1f 6 Jan 2014

[SimpleApp]

@sideshow Same here, used LibreSSL 2.2.7 (mac OS High Sierra 10.13.1)

[sideshow]

Thanks for the PR :)

[jameshfisher]

thanks! :)