Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VerifyHostname certificate validation on go1.11 #115

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

sideshow
Copy link
Owner

@sideshow sideshow commented Aug 14, 2018

Changes tests to pass on go1.11 as VerifyHostname returns an error. Instead we now check that the certificate returned is not a blank one.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.753% when pulling fa5a471 on fix-cert-host-validation into c6554af on master.

@sideshow sideshow merged commit 656cc74 into master Aug 14, 2018
@sideshow sideshow deleted the fix-cert-host-validation branch October 13, 2018 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants