Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alert action key. #18

Closed
wants to merge 1 commit into from
Closed

Conversation

appleboy
Copy link
Contributor

Action key is not exist in alert property.

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cfbfaac on appleboy:patch-2 into 729daff on sideshow:master.

@sideshow
Copy link
Owner

This one is required for Safari Push Notifications. ie, example payload;

{
    "aps": {
        "alert": {
            "title": "Flight A998 Now Boarding",
            "body": "Boarding has begun for Flight A998.",
            "action": "View"
        },
        "url-args": ["boarding", "A998"]
    }
} 

https://developer.apple.com/library/mac/documentation/NetworkingInternet/Conceptual/NotificationProgrammingGuideForWebsites/PushNotifications/PushNotifications.html#//apple_ref/doc/uid/TP40013225-CH3-SW12

@appleboy
Copy link
Contributor Author

@sideshow Good catch. I am missing the page about Safari Push Notifications.

@appleboy appleboy closed this Apr 13, 2016
@nathany
Copy link

nathany commented Apr 14, 2016

Just fyi, the way I went with Buford is to have a separate Browser struct just for Safari.

https://github.com/RobotsAndPencils/buford/blob/master/payload/browser.go

@appleboy
Copy link
Contributor Author

@nathany Nice...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants