Solving issue #89: #110
Solving issue #89: #110
Conversation
mazoni
commented
Feb 21, 2017
mazoni
commented
- Special treatment to customHeader keyword to be added as a list to the metadata
- Specs covering single and multiple customHeader keywords
- README file updated to match the above changes
- Special treatment to customHeader keyword to be added as a list to the metadata - Specs covering single and multiple customHeader keywords - README file updated to match the above changes
| @@ -144,7 +143,14 @@ Canned.prototype.parseMetaData = function(response) { | |||
| return parts.join(':') | |||
| }).join(',') | |||
| var opts = JSON.parse('{' + content + '}') | |||
| cannedUtils.extend(metaData, opts) | |||
| if(opts.hasOwnProperty('customHeader')) { | |||
| if(metaData.hasOwnProperty('customHeaders')) metaData.customHeaders.push(opts.customHeader) | |||
There was a problem hiding this comment.
Is that a common way to format? Just wondering as I've never seen if without curly but else with curly.
There was a problem hiding this comment.
Do we need both customHeaders and customHeader?
There was a problem hiding this comment.
You're right, @sideshowcoder looks weird. Will fix it.
About customHeaders and customHeader the thing is that to take advantage of all the work regarding metaData having a customHeadears attribute and this was already set to the response.
So customHeaders is only the name of the list in metadata not an accepted header in canned.
| @@ -10,6 +10,8 @@ describe('canned', function () { | |||
| can = canned('./spec/test_responses') | |||
| req = { method: 'GET' } | |||
| res = { setHeader: function () {}, end: function () {} } | |||
| spyOn(res, 'setHeader') | |||
There was a problem hiding this comment.
Is the spy needed here? Overriding the setHeader function should do fine or am I missing something.
There was a problem hiding this comment.
Yes, in this particular case. In lines 139, 148 and 149 I have some cases where the setHeader will be called multiple times and setting the setHeader function fails since it ends up testing the wrong header.
So to cover the case that a certain header was set independently from what was set before, I needed the spy.
|
Sorry for the delay, but the new version (0.3.10) has been released. |
