Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frost DK: Unknown spell with ID potion used in Spell(potion). #61

Closed
Hemario opened this issue Aug 28, 2016 · 3 comments
Closed

Frost DK: Unknown spell with ID potion used in Spell(potion). #61

Hemario opened this issue Aug 28, 2016 · 3 comments

Comments

@Hemario
Copy link
Contributor

Hemario commented Aug 28, 2016

Spell(potion) should probably translate into calling function FrostUsePotionStrength().

Does this only happen in Frost DK script?
Should the simc action "potion,type=draenic_strength" be translated differently?

@Hemario
Copy link
Contributor Author

Hemario commented Aug 28, 2016

From first analysis it seems that the simc script has an issue.
It uses the type modifier while the name modifier is expected.

@Sidoine a couple of questions

  1. where do you get the simc scripts? Are they an exact copy of what the simc community creates and no special actions added before import into Ovale?
  2. do the Ovale scripts get generated each time the simc scripts are updated?

@Hemario
Copy link
Contributor Author

Hemario commented Aug 30, 2016

@Sidoine
Copy link
Owner

Sidoine commented Sep 19, 2016

It uses the scripts from their source code.
The translation code should support the two parameter names now.

@Sidoine Sidoine closed this as completed Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants