Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frost DK] potion,type instead of potion,name #2795

Closed
Hemario opened this issue Aug 30, 2016 · 4 comments
Closed

[Frost DK] potion,type instead of potion,name #2795

Hemario opened this issue Aug 30, 2016 · 4 comments
Labels

Comments

@Hemario
Copy link

Hemario commented Aug 30, 2016

I'm not entirely sure but all frost DK scripts mention actions+=/potion,type=deadly_grace in the in-combat rotation.
The prepot action says actions.precombat+=/potion,name=deadly_grace

Which one is the correct one?

@navv1234
Copy link
Contributor

Either works.

@navv1234
Copy link
Contributor

navv1234 commented Sep 1, 2016

If one or the other is easier for ovale (name was the original one), I can adjust the default APL as necessary. We don't really care either way.

@Hemario
Copy link
Author

Hemario commented Sep 1, 2016

It will prevent us having to facilitate both.
It should be a simple "or" statement in the place where we check the name.

Why is there a difference anyway if they do the same thing?
Wouldn't it be just easier to delete the "type" functionality and go with name always?

@navv1234
Copy link
Contributor

navv1234 commented Sep 7, 2016

I now changed DKs and Rogues to use "name" across the board (flasks, potions, food, augments). I can't speak for other class modules at the moment.

@Collisionc Collisionc added this to the release-703-02 milestone Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants