Integrate infection/infection to improve tests quality
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maks-rafalko
commented
May 23, 2023
.github/workflows/ci.yaml
Outdated
|
|
||
| - name: Run Infection | ||
| shell: bash | ||
| run: make infection |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Could you please rebase against latest master and resolve conflicts? |
maks-rafalko
force-pushed
the
feature/infection
branch
2 times, most recently
from
cf3d831
to
93dca13
Compare
…ng cases for Equal and NotEqual
…ng cases where rule should not be triggered
…ding cases where null is assigned
maks-rafalko
force-pushed
the
feature/infection
branch
from
93dca13
to
336304d
Compare
|
@sidz ready for review Here you can see Infection takes almost 2m when executed for the whole project: https://github.com/sidz/phpstan-rules/actions/runs/5126088310/jobs/9220118095#step:9:1 After running it for the changed lines only, it takes 1s (for this particular PR because no source files are changed): https://github.com/sidz/phpstan-rules/actions/runs/5126162099/jobs/9220300054#step:9:1 But anyway, this is a good improvement. Regarding MSI, it's now 100% |
Fine for me to leave it as is. |
|
Thank you @maks-rafalko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #7 and #8
Currently in Draft, to trigger CI and see if it works in some way.
mt.yamlto run it only for one PHP version