Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Cannot configure number of LocalManagers #241

Closed
maverickwoo opened this issue Dec 30, 2020 · 1 comment · Fixed by #242
Closed

Web: Cannot configure number of LocalManagers #241

maverickwoo opened this issue Dec 30, 2020 · 1 comment · Fixed by #242
Assignees
Labels
bug Something isn't working reproduced We have reproduced the issue

Comments

@maverickwoo
Copy link

In latest master as of this writing (f4781fc), the guard at

if agentType is not None and agentType != 4:

inside insertFormInputForConfiguredInstances watches over every line until:

return "Configured Instances!", "success"

This leads to the backend ignoring the number of requested LMs in the posted form while returning a success message to be displayed in the browser.

@p0wer0xff p0wer0xff added bug Something isn't working reproduced We have reproduced the issue labels Jan 20, 2021
@jones718
Copy link
Collaborator

Thanks for pointing out this bug. It will be fixed with PR #242

@jones718 jones718 self-assigned this Jan 27, 2021
@p0wer0xff p0wer0xff linked a pull request Jan 28, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reproduced We have reproduced the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants