Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/application): app switch #1007

Merged
merged 54 commits into from
Jan 10, 2024
Merged

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Dec 15, 2023

💡 What is the current behavior?

🆕 What is the new behavior?

  • deprecate basic-navigation and map-navigation
  • Remove @internal from ix-application, ix-content, ix-application-header
  • Add app switch feature to ix-application
  • Create content area for ix-application-header
  • Fix broken eslint in core, (fix major eslint incidents)

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (yarn docs)
  • 🧪 Unit tests were added/updated and pass (yarn test)
  • 📸 Visual regression tests were added/updated and pass (yarn visual-regression)
  • 🧐 Static code analysis passes (yarn lint)
  • 🏗️ Successful compilation (yarn build, changes pushed)

👨‍💻 Help & support

@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label Dec 15, 2023
@danielleroux danielleroux added this to the 2.1.0 milestone Dec 15, 2023
@danielleroux danielleroux changed the title Feat/cross app navigation feat(core/application): app switch Dec 15, 2023
@danielleroux danielleroux marked this pull request as ready for review December 22, 2023 06:08
…tion.md

Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
nuke-ellington
nuke-ellington previously approved these changes Jan 8, 2024
@danielleroux danielleroux merged commit 3298e87 into main Jan 10, 2024
6 checks passed
@danielleroux danielleroux deleted the feat/cross-app-navigation branch January 10, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: application header for basic navigation
2 participants