Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tooltip positioning #1036

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Conversation

ridvandmrc
Copy link
Contributor

@ridvandmrc ridvandmrc commented Jan 9, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: 823

What is the new behavior?

  • Tooltip shown top-left initially.
  • initially, it gives undefine error

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@danielleroux danielleroux linked an issue Jan 9, 2024 that may be closed by this pull request
@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Jan 9, 2024
@danielleroux danielleroux added this to the 2.1.0 milestone Jan 9, 2024
@danielleroux danielleroux merged commit 9ba9823 into siemens:main Jan 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip: visual issue on first use
2 participants